netdev - Re: [PATCH net-next V6 12/14] bridge: Add vlan support to static neighbors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kd81eh$ptv$3@ger.gmane.org>
Date:	Thu, 17 Jan 2013 05:16:02 +0000 (UTC)
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next V6 12/14] bridge: Add vlan support to static
 neighbors

On Wed, 16 Jan 2013 at 18:18 GMT, Vlad Yasevich <vyasevic@...hat.com> wrote:
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index a244efc..90d0bc9 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -506,6 +506,10 @@ static int fdb_fill_info(struct sk_buff *skb, const struct net_bridge *br,
>  	ci.ndm_refcnt	 = 0;
>  	if (nla_put(skb, NDA_CACHEINFO, sizeof(ci), &ci))
>  		goto nla_put_failure;
> +
> +	if (nla_put(skb, NDA_VLAN, sizeof(u16), &fdb->vlan_id))
> +		goto nla_put_failure;

Why not just nla_put_u16()?


> +
> +		/* We have vlans configured on this port and user didn't
> +		 * specify a VLAN.  To be nice, add/update entry for every
> +		 * vlan on this port.
> +		 */
> +		err = -ENOENT;
> +		list_for_each_entry_rcu(pve, &p->vlan_info.vlan_list, list) {
> +			err &= __br_fdb_delete(p, addr, pve->vid);
> +		}

 '&=' or '|='?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html