netdev - Re: [Patch net-next 1/2] xfrm: replace rwlock on xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358403766.3855.21.camel@cr0>
Date:	Thu, 17 Jan 2013 14:22:46 +0800
From:	Cong Wang <amwang@...hat.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Cc:	netdev@...r.kernel.org,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next 1/2] xfrm: replace rwlock on xfrm_state_afinfo
 with rcu

On Wed, 2013-01-16 at 22:57 +0900, YOSHIFUJI Hideaki wrote:
> Cong Wang wrote:
> >  
> >  static void xfrm_state_unlock_afinfo(struct xfrm_state_afinfo *afinfo)
> > -	__releases(xfrm_state_afinfo_lock)
> >  {
> > -	write_unlock_bh(&xfrm_state_afinfo_lock);
> > +	spin_unlock_bh(&xfrm_state_afinfo_lock);
> >  }
> >  
> >  int xfrm_register_type(const struct xfrm_type *type, unsigned short family)
> 
> Why removing __releases() hint?

There is no __acquires matched:
% git grep __acquires -- net/xfrm 
<nothing output>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html