| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jan 2013 10:35:15 +0200 From: Timo Teras <timo.teras@....fi> To: Steffen Klassert <steffen.klassert@...unet.com> Cc: David Miller <davem@...emloft.net>, Julian Anastasov <ja@....bg>, luky-37@...mail.com, pupilla@...ero.it, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] ipv4: Remove output route check in ipv4_mtu On Thu, 17 Jan 2013 07:55:01 +0100 Steffen Klassert <steffen.klassert@...unet.com> wrote: > The output route check was introduced with git commit 261663b0 > (ipv4: Don't use the cached pmtu informations for input routes) > during times when we cached the pmtu informations on the > inetpeer. Now the pmtu informations are back in the routes, > so this check is obsolete. It also had some unwanted side effects, > as reported by Timo Teras and Lukas Tribus. > > Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com> > --- Acked-by: Timo Teräs <timo.teras@....fi> I think this should also go to stable queues which are applicable, since the original commit caused CLAMPMSS and XFRM pmtu regressions. The original thread of this is: http://marc.info/?t=134208398500001&r=1&w=2 My original revert request is at: http://marc.info/?l=linux-netdev&m=134242561624266&w=2 and additional reasoning at: http://marc.info/?l=linux-netdev&m=134243626627716&w=2 Thanks, Timo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists