netdev - Re: [PATCH v2] net: fix wrong length of mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20130118.143624.1891658456904822247.davem@davemloft.net>
Date:	Fri, 18 Jan 2013 14:36:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	WaskiewiczJr@...askie-mobl2
Cc:	kongjianjun@...il.com, kys@...rosoft.com, haiyangz@...rosoft.com,
	netdev@...r.kernel.org, devel@...uxdriverproject.org
Subject: Re: [PATCH v2] net: fix wrong length of mac address

From: PJ Waskiewicz <WaskiewiczJr@...askie-mobl2>
Date: Fri, 18 Jan 2013 00:30:32 -0800

> On Fri, Jan 18, 2013 at 03:51:54PM +0800, Amos Kong wrote:
>> Typo, it should be ETH_ALEN.
>> 
>> Signed-off-by: Amos Kong <kongjianjun@...il.com>
>> ---
>> v2: update commitlog, fix cc list
>> ---
>>  drivers/net/hyperv/netvsc_drv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
>> index f825a62..8264f0e 100644
>> --- a/drivers/net/hyperv/netvsc_drv.c
>> +++ b/drivers/net/hyperv/netvsc_drv.c
>> @@ -349,7 +349,7 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
>>  	struct net_device_context *ndevctx = netdev_priv(ndev);
>>  	struct hv_device *hdev =  ndevctx->device_ctx;
>>  	struct sockaddr *addr = p;
>> -	char save_adr[14];
>> +	char save_adr[ETH_ALEN];
>>  	unsigned char save_aatype;
>>  	int err;
> 
> While you're at it, you should also update drivers/net/hyperv/hyperv_net.h
> to also fix the mac_adr definition in struct netvsc_device_info:
> 
> struct netvsc_device_info {
>>>>     unsigned char mac_adr[6];

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html