netdev - Re: Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201301172314.34193.vapier@gentoo.org>
Date:	Thu, 17 Jan 2013 23:14:31 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	libc-alpha@...rceware.org
Cc:	David Miller <davem@...emloft.net>, bhutchings@...arflare.com,
	yoshfuji@...ux-ipv6.org, amwang@...hat.com, tmb@...eia.org,
	eblake@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, libvirt-list@...hat.com,
	tgraf@...g.ch, schwab@...e.de, carlos@...temhalted.org
Subject: Re: Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>

On Wednesday 16 January 2013 16:45:11 David Miller wrote:
> What would be really nice is if GCC treated multiple identical
> definitions of structures the same way it handles multiple identical
> definitions of CPP defines.  Which is to silently accept them.
> 
> But that's not the case, so we need a different solution.
> 
> Another thing to do is to use a new structure for in6_addr in kernel
> headers exported to userland.

the kernel already exports many types with a __kernel_ prefix.  i changed the 
kernel headers in Gentoo for a few releases (2.6.28 - 2.6.34) to do the same 
thing to pretty much all the networking headers.  a few packages broke, but 
the number was low, and trivial to fix (a sed would do it most of the time).

it's also trivial for userland packages to detect that they need to do this 
sort of thing in a local header by using linux/version.h and a set of defines 
to redirect the new structure name back to the old one.

would be a lot cleaner to just break it and be done.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)