netdev - Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F8DA3A.3090406@ti.com>
Date:	Fri, 18 Jan 2013 10:44:34 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Peter Korsgaard <jacmet@...site.dk>
CC:	<linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <hvaibhav@...com>,
	<richardcochran@...il.com>, <tony@...mide.com>,
	<michal.bachraty@...il.com>, <michal.bachraty@...eamunlimited.com>
Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse
 if not defined in dt

On 1/18/2013 3:48 AM, Peter Korsgaard wrote:
> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old
> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot
> mode in U-Boot), nothing updates the ethernet hwaddr specified for the
> CPSW slaves, causing the driver to use a random hwaddr, which is some times
> troublesome.
>
> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes
> more sense to default to these rather than random ones. Add a fixup step
> which adds mac-address dt properties using the efuse addresses if the DTB
> didn't contain valid ones.
>
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
>

This implementation looks fine.
Acked-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html