netdev - Re: [PATCH] net: usb: initialize tmp in dm9601.c to avoid warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fw1ykhhj.fsf@dell.be.48ers.dk>
Date:	Fri, 18 Jan 2013 09:44:40 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	David Miller <davem@...emloft.net>
Cc:	sque@...omium.org, netdev@...r.kernel.org, msb@...omium.org
Subject: Re: [PATCH] net: usb: initialize tmp in dm9601.c to avoid warning

>>>>> "David" == David Miller <davem@...emloft.net> writes:

 >> Sure, I just wondered as the code hasn't changed in 5+ years, and the
 >> function that gets called is defined just above, so the compiler should
 >> be able to figure it out.

 David> Nothing guarentees that a piece of memory passed into an external
 David> function has it's contents initialized completely by that function.

 David> The compiler can't see what usbnet_read_cmd() does with the memory
 David> behind the 'data' pointer argument.  So it makes the only assumption
 David> it can make, which is that 'tmp' might be uninitialized.

True, I had forgotten about the usbnet_read_cmd() change (which is the
change causing the warning). With that:

Acked-by: Peter Korsgaard <jacmet@...site.dk>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html