netdev - Re: [PATCH v4 2/3] net: split eth_mac_addr for better error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130121161328.GE24473@stefanha-thinkpad.redhat.com>
Date:	Mon, 21 Jan 2013 17:13:28 +0100
From:	Stefan Hajnoczi <stefanha@...il.com>
To:	akong@...hat.com
Cc:	mst@...hat.com, kvm@...r.kernel.org, netdev@...r.kernel.org,
	qemu-devel@...gnu.org, virtualization@...ts.linux-foundation.org,
	davem@...emloft.net
Subject: Re: [PATCH v4 2/3] net: split eth_mac_addr for better error handling

On Sun, Jan 20, 2013 at 10:43:08AM +0800, akong@...hat.com wrote:
> From: Stefan Hajnoczi <stefanha@...il.com>
> 
> When we set mac address, software mac address in system and hardware mac
> address all need to be updated. Current eth_mac_addr() doesn't allow
> callers to implement error handling nicely.
> 
> This patch split eth_mac_addr() to prepare part and real commit part,
> then we can prepare first, and try to change hardware address, then do
> the real commit if hardware address is set successfully.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@...il.com>
> Signed-off-by: Amos Kong <akong@...hat.com>
> ---
>  include/linux/etherdevice.h |  2 ++
>  net/ethernet/eth.c          | 43 ++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 38 insertions(+), 7 deletions(-)

Feel free to make yourself author and put me just as Suggested-by:.  I
posted pseudo-code but didn't write the patch or test it, so it's fair
to say that credit goes to you. :)

Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html