netdev - Re: [PATCH net-next 00/19] IPv6 NDISC Updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130121.133527.1399553564620986529.davem@davemloft.net>
Date:	Mon, 21 Jan 2013 13:35:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 00/19] IPv6 NDISC Updates

From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Tue, 22 Jan 2013 01:47:40 +0900

> This series of changes basically clean up NDISC logic,
> especially on sender side.

This series looks great, applied.

In patch #4 you add a check on rd_len such that the option is only
constructed if rd_len is non-zero, I'd like you to enhance this so
that it's easier to understand.

I can't convince myself either that rd_len can never be zero, or that
when it is zero we do not still put the uninitialized 'opt' into the
packet and out on the wire.

Using either assertions of descriptive comments, explain why all of
these problems will not arise.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html