netdev - Re: v3 for tcp friends?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50FCEE64.80203@gmail.com>
Date:	Mon, 21 Jan 2013 15:29:40 +0800
From:	Li Yu <raise.sail@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	brutus@...gle.com, netdev@...r.kernel.org
Subject: Re: v3 for tcp friends?

于 2012年09月05日 00:58, David Miller 写道:
> From: Bruce Curtis <brutus@...gle.com>
> Date: Tue, 4 Sep 2012 08:10:23 -0700
>
>> Will do, issues addressed, I'll get the patch out later today or
>> tomorrow at the latest.
>
> Thanks a lot Bruce.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


Hi, Bruce,

	I tested the TCP friends, found a bug here:

[  106.541372] Pid: 1765, comm: client Not tainted 3.7.0-rc1+ #25
[  106.543121] Call Trace:
[  106.543950]  [<ffffffff8133d212>] inet_sock_destruct+0x102/0x1f0
[  106.545687]  [<ffffffff812c38ad>] __sk_free+0x1d/0x110
[  106.547209]  [<ffffffff812c3a1c>] sk_free+0x1c/0x20
[  106.548611]  [<ffffffff8131680c>] tcp_close+0x6c/0x3f0
[  106.549863]  [<ffffffff8133caea>] inet_release+0xda/0xf0
[  106.551134]  [<ffffffff8133ca30>] ? inet_release+0x20/0xf0
[  106.552419]  [<ffffffff8137f3de>] ? mutex_unlock+0xe/0x10
[  106.553658]  [<ffffffff812bf948>] sock_release+0x28/0xa0
[  106.557366]  [<ffffffff812bfd69>] sock_close+0x29/0x30
[  106.558831]  [<ffffffff81128972>] __fput+0x122/0x210
[  106.560541]  [<ffffffff81128a6e>] ____fput+0xe/0x10
[  106.562006]  [<ffffffff8105354e>] task_work_run+0x9e/0xd0
[  106.563285]  [<ffffffff810027e1>] do_notify_resume+0x61/0x70
[  106.564582]  [<ffffffff8138a908>] int_signal+0x12/0x17


	I also backported and tested it on stable kernel 3.7.3/RHEL6
kernel, this bug still exists. It seem that client may close listening
sockets, may we need to add one reference count for listen socket
before send its address to peer?

	And, our TCP friends v4? :)

	Thanks

Yu

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html