netdev - Re: [PATCH 2/2] CDC_NCM: adding support FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACa7zyncby5Tdizx85CxoxirdGrO-ocshp43oNEyokLzZboX_A@mail.gmail.com>
Date:	Mon, 21 Jan 2013 16:22:47 +0800
From:	Wei Shuai <cpuwolf@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sshtylyov@...sta.com, dcbw@...hat.com, peter@...ge.se,
	oneukum@...e.de, gregkh@...uxfoundation.org,
	alexey.orishko@...ricsson.com, bjorn@...k.no,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

Thank you David. yes in the core driver, FLAG_NOARP will be translated
to IFF_NOARP

2013/1/21, David Miller <davem@...emloft.net>:
> From: Wei Shuai <cpuwolf@...il.com>
> Date: Mon, 21 Jan 2013 10:20:22 +0800
>
>> The main problem is that these devices don't support ethernet.
>
> He's saying your comment is referring to the wrong thing,
> rather than saying anything against what your change is
> doing.
>
> Read his feedback carefully:
>
>>>> +/* Same as wwan_info, but with IFF_NOARP  */
>>>
>>>     FLAG_NOARP, you mean?
>
> He's saying your commnet is talking about FLAG_NOARP rather
> than what the core code does with this flag, which is
> translate into setting IFF_NOARP on the net device.
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html