netdev - Re: r8169 doing more work than napi weight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130121234205.GA12449@electric-eye.fr.zoreil.com>
Date:	Tue, 22 Jan 2013 00:42:05 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Timo Teras <timo.teras@....fi>
Cc:	netdev@...r.kernel.org
Subject: Re: r8169 doing more work than napi weight

Timo Teras <timo.teras@....fi> :
[...]
> Or just delete the whole block as obsolete. 'git log' says the problem
> should have gone away by always using hardware Rx VLAN. See commit
> 05af214 "r8169: fix Ethernet Hangup for RTL8110SC rev d".

Yes, this stuff looks really strange.

Turning the whole "(desc->opts2 & cpu_to_le32(0xfffe000)) && ... " test
as a WARN_ON_ONCE in the RxRES branch seems a good trade-off from a
coward's viewpoint.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html