lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jan 2013 11:04:10 +0200 (EET) From: Julian Anastasov <ja@....bg> To: Steffen Klassert <steffen.klassert@...unet.com> cc: David Miller <davem@...emloft.net>, "Yurij M. Plotnikov" <Yurij.Plotnikov@...etlabs.ru>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] ipv4: Invalidate the socket cached route on pmtu events if possible Hello, On Tue, 22 Jan 2013, Steffen Klassert wrote: > > Another variant is to remember with flag 'new_rt' > > that we should call __sk_dst_set, eg. when rt comes from > > ip_route_output_flow. By this way we can avoid some of > > the dst_hold/dst_release calls if sk_dst_cache is not > > changed. IIRC, according to sk_dst_check, dst_check can > > not return different dst from the ->check method. > > > > With this variant, we also need to check the new_rt flag > before we call the dst_release() function you mentioned > above, right? Yes, also before the dst_release we add after the first ip_route_output_flow. > I think we should avoid refcounts whenever we can, > so I prefer this variant. I'll do a patch. Yes, the flag is preferred because we should keep sk_dst_cache until we decide to replace it with __sk_dst_set. Regards -- Julian Anastasov <ja@....bg> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists