[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1621221.QORYF6fjNM@linux-5eaq.site>
Date: Tue, 22 Jan 2013 10:07:07 +0100
From: Oliver Neukum <oneukum@...e.de>
To: Alexey ORISHKO <alexey.orishko@...ricsson.com>
Cc: Bjørn Mork <bjorn@...k.no>,
Alexey Orishko <alexey.orishko@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
Greg Suarez <gsuarez@...thmicro.com>
Subject: Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote:
> Specification says:
> NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize.
>
> The problem is:
> dwNtbOutMaxSize value is negotiated between host and device NCM/MBIM
> entities and usbnet has no knowledge about it.
>
> Adding one byte to make buffer looking like a short packet was most
> simple approach instead of inventing a way to communicate
> dwNtbOutMaxSize to usbnet.
>
> You could drop short packet approach if dwNtbOutMaxSize is provided
> to usbnet and decision is made accordingly to NCM/MBIM spec (with
> exception to faulty devices).
We could do that. Feel free to send a patch. ;-)
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists