netdev - Re: [PATCH] [RFC] tcp: add ability to set a timestamp offset (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130123162025.GA2147@ms2.inr.ac.ru>
Date:	Wed, 23 Jan 2013 20:20:25 +0400
From:	Alexey Kuznetsov <kuznet@....inr.ac.ru>
To:	Andrey Vagin <avagin@...nvz.org>
Cc:	netdev@...r.kernel.org, criu@...nvz.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Dave Jones <davej@...hat.com>,
	Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH] [RFC] tcp: add ability to set a timestamp offset (v2)

Hello!

On Wed, Jan 23, 2013 at 07:01:52PM +0400, Andrey Vagin wrote:
> -#define tcp_time_stamp         ((__u32)(jiffies))
> +#define tcp_time_stamp(tp)     ((__u32)(jiffies) + tp->tsoffset)

This implies that you always have some tp in hands. AFAIK this is not true,
so that I am puzzled how you were able to make something compilable with this definition.

At least in tcp_v4_send_ack() you obviously use some invalid tp, there is
no socket in hands there. The thing which is called "sk" is dummy.

With container migration I used per-container offset. When you have no container,
you have to do something a little bit smarter.

Alexey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html