netdev - Re: [Patch net-next] net: add RCU annotation to sk_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358917086.4235.12.camel@cr0>
Date:	Wed, 23 Jan 2013 12:58:06 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field

On Tue, 2013-01-22 at 20:50 -0800, Eric Dumazet wrote:
> On Wed, 2013-01-23 at 12:43 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@...hat.com>
> > 
> > sock->sk_dst_cache is protected by RCU.
> > 
> > Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> > Cc: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> > 
> > ---
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 5a34e2f..c4b64c6 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -337,7 +337,7 @@ struct sock {
> >  #endif
> >  	unsigned long 		sk_flags;
> >  	struct dst_entry	*sk_rx_dst;
> > -	struct dst_entry	*sk_dst_cache;
> > +	struct dst_entry __rcu	*sk_dst_cache;
> >  	spinlock_t		sk_dst_lock;
> >  	atomic_t		sk_wmem_alloc;
> >  	atomic_t		sk_omem_alloc;
> 
> Thats not a complete patch.
> 
> You'll have to fix the errors it brings.

It does fix this warning:

net/core/flow_dissector.c:280:37: sparse: incompatible types in
comparison expression (different address spaces)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html