netdev - Re: [patch] Gianfar : Enable promiscous mode after queue time out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50FFB45E.6030201@freescale.com>
Date:	Wed, 23 Jan 2013 11:58:54 +0200
From:	Claudiu Manoil <claudiu.manoil@...escale.com>
To:	Cedric VONCKEN <cedric.voncken@...sys.fr>
CC:	<netdev@...r.kernel.org>
Subject: Re: [patch]  Gianfar : Enable promiscous mode after queue time out

On 1/21/2013 6:24 PM, Cedric VONCKEN wrote:
> 	Hi all,
>
> 	When the Netdev tx queue timeout occurred, the function
> gfar_timeout(..) is called. This function calls indirectly the
> gfar_init_mac(..) function.
>
>   	In this function, the rctrl register is set to a default value.
>
>   	If the Promiscuous is enable on the net dev ( flag IFF_PROMISC
> is  set), the gfar_init_function does not reactivate it.
>
>   	The Promiscuous mode is used for example when the netdev is
> bridged.
>   	
>   	I apply this patch on the kernel 3.8-rc4 to fix it.
>
> 	Signed-off-by : Voncken C Acksys <cedric.voncken@...sys.fr>
>
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -349,6 +349,11 @@ static void gfar_init_mac(struct net_dev
>   	/* Configure the coalescing support */
>   	gfar_configure_coalescing(priv, 0xFF, 0xFF);
>
> +	if (ndev->flags & IFF_PROMISC) {
> +		/* Set RCTRL to PROM */
> +		rctrl |= RCTRL_PROM;
> +	}
> +
>   	if (priv->rx_filer_enable) {
>   		rctrl |= RCTRL_FILREN;
>   		/* Program the RIR0 reg with the required distribution
> */
>
>
>
>
>

Hello Cedric,

I'll take care of this code change and I'll send a properly formatted 
patch for it.
Besides, gfar_init_mac() may be called for numerous other reasons than 
tx timeout, like changing MTU, changing ring params, restoring the 
interface etc. (any reset condition), so I'll rephrase the patch comment 
too.

Thanks,
Claudiu


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html