netdev - Re: [PATCH net-next] via-rhine: add 64bit statistics.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5100819b.2605650a.1e3b.ffffe312@mx.google.com>
Date:	Wed, 23 Jan 2013 20:34:27 -0400
From:	Jamie Gloudon <jamie.gloudon@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] via-rhine: add 64bit statistics.

On Wed, Jan 23, 2013 at 04:27:42PM -0800, Eric Dumazet wrote:
> On Wed, 2013-01-23 at 20:20 -0400, Jamie Gloudon wrote:
> 
> > Right. Also, I added rx_dropped to increment for oversize ethernet. Is
> > that valid?
> > 
> > @@ -1857,6 +1869,7 @@ static int rhine_rx(struct net_device *dev, int
> > limit)
> > 	"Oversized Ethernet frame %p vs %p\n", rp->rx_head_desc,                        	&rp->rx_ring[entry]);
> > +	dev->stats.rx_dropped++;
> > 	dev->stats.rx_length_errors++;
> 
> Take other drivers as reference
> 
> git grep -n2 rx_length_errors -- drivers/net
> 
> Most of them dont do that (they are more likely increasing rx_errors)
> 
>

Alright then, I will remove that line and queue up another patch for submission.
Thanks for the feedback!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html