netdev - Re: [PATCH 1/2 net-next] net: fec: add napi support to improve proformance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130124063917.GA27481@ppwaskie-mobl2.amr.corp.intel.com>
Date:	Wed, 23 Jan 2013 22:39:18 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Frank Li <lznuaa@...il.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Frank Li <Frank.Li@...escale.com>, shawn.guo@...aro.org,
	B38611@...escale.com, davem@...emloft.net,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	bhutchings@...arflare.com, s.hauer@...gutronix.de
Subject: Re: [PATCH 1/2 net-next] net: fec: add napi support to improve
 proformance

On Thu, Jan 24, 2013 at 10:26:00AM +0800, Frank Li wrote:
> > A NAPI driver must call netif_receive_skb(), especially if
> > the RX path does a full copy of the frame : Its hot in cpu cache and
> > should be processed at once.
> 
> How about napi_gro_receive? is it correct function? I found many driver use it.

If you want to coalesce your Rx frames to reduce overhead, then yes.  It's
a good performance improvement overall.

-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html