netdev - Re: [PATCH] tcp: Increment of LINUX_MIB_LISTENOVERFLOWS in tcp_v4_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51023742.2000908@gmail.com>
Date:	Thu, 24 Jan 2013 23:41:54 -0800
From:	Nivedita Singhvi <niveditasinghvi@...il.com>
To:	Vijay Subramanian <subramanian.vijay@...il.com>
CC:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Leandro Lucarella <leandro.lucarella@...iomantic.com>,
	Nivedita Singhvi <niv@...ibm.com>
Subject: Re: [PATCH] tcp: Increment of LINUX_MIB_LISTENOVERFLOWS in tcp_v4_conn_request()

On 01/24/2013 11:29 PM, Vijay Subramanian wrote:
> On 24 January 2013 23:03, Nivedita Singhvi <niveditasinghvi@...il.com> wrote:
>> We drop a connection request if the accept backlog, syn queue are full when processing reaches tcp_v4_conn_request(). Increment the appropriate counter so this isn't silent, for accurate stats and help in debugging.
>>
> 
> Commit message seems misleading. syn queue is not really full at this
> point. It just has more than enough entries.

Er, good point. I should have said "sufficiently full" or "warm 
enough to warrant starting drops" - hope I'm not confusing 
things further, am I? DaveM, would you like me to resend, if you're 
picking this up? 


thanks,
Nivedita


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html