netdev - Re: [Patch net-next v2 2/2] netpoll: use the net namespace of current process instead of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130128.183338.211219305250941993.davem@davemloft.net>
Date:	Mon, 28 Jan 2013 18:33:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [Patch net-next v2 2/2] netpoll: use the net namespace of
 current process instead of init_net

From: Cong Wang <amwang@...hat.com>
Date: Mon, 28 Jan 2013 09:55:21 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> This will allow us to setup netconsole in a different namespace
> rather than where init_net is.
> 
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Applied but:

> +	if (np->dev_name) {
> +		struct net *net = current->nsproxy->net_ns;
> +		ndev = __dev_get_by_name(net, np->dev_name);
> +	}

I wonder if you should be using task_nsproxy() here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html