netdev - Re: [PATCH] net: wireless/ath: Fix compile error seen with W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2013 12:55:37 +0200
From:	Vladimir Kondratiev <qca_vkondrat@....qualcomm.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	"John W. Linville" <linville@...driver.com>,
	<linux-wireless@...r.kernel.org>, <wil6210@....qualcomm.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] net: wireless/ath: Fix compile error seen with W=1

On Saturday, January 26, 2013 06:26:08 PM Guenter Roeck wrote:
> make W=1 for x86_64 fails with
> 
> drivers/net/wireless/ath/wil6210/txrx.c: In function ‘wil_rx_fini’:
> drivers/net/wireless/ath/wil6210/txrx.c:550:7: error: variable ‘rc’ set but not
> used [-Werror=unused-but-set-variable]
> 
> Fix by dropping the variable.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/net/wireless/ath/wil6210/txrx.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
> index f29c294..b6e8042 100644
> --- a/drivers/net/wireless/ath/wil6210/txrx.c
> +++ b/drivers/net/wireless/ath/wil6210/txrx.c
> @@ -547,7 +547,6 @@ void wil_rx_fini(struct wil6210_priv *wil)
>  	struct vring *vring = &wil->vring_rx;
>  
>  	if (vring->va) {
> -		int rc;
>  		struct wmi_cfg_rx_chain_cmd cmd = {
>  			.action = cpu_to_le32(WMI_RX_CHAIN_DEL),
>  			.rx_sw_ring = {
> @@ -559,7 +558,7 @@ void wil_rx_fini(struct wil6210_priv *wil)
>  			struct wmi_cfg_rx_chain_done_event cfg;
>  		} __packed wmi_rx_cfg_reply;
>  
> -		rc = wmi_call(wil, WMI_CFG_RX_CHAIN_CMDID, &cmd, sizeof(cmd),
> +		(void)wmi_call(wil, WMI_CFG_RX_CHAIN_CMDID, &cmd, sizeof(cmd),
>  			      WMI_CFG_RX_CHAIN_DONE_EVENTID,
>  			      &wmi_rx_cfg_reply, sizeof(wmi_rx_cfg_reply),
>  			      100);
> 

Thanks for finding it.

I will send series of new patches shortly. This will include changes in
rx chain initialization that, among other, remove fragment you fixed.
Reason is firmware API changes.

Thanks, Vladimir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html