netdev - Re: [net-next 14/14] igbvf: be sane about random MAC addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51065CDA.90307@redhat.com>
Date:	Mon, 28 Jan 2013 12:11:22 +0100
From:	Stefan Assmann <sassmann@...hat.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	davem@...emloft.net, Mitch A Williams <mitch.a.williams@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com,
	Andy Gospodarek <andy@...yhouse.net>,
	Stefan Assmann <sassmann@...nic.de>
Subject: Re: [net-next 14/14] igbvf: be sane about random MAC addresses

On 28.01.2013 10:04, Jeff Kirsher wrote:
> From: Mitch A Williams <mitch.a.williams@...el.com>
> 
> Tighten up some of the code surrounding MAC addresses. Since the PF is
> now giving all zeros instead of a random address, check for this case
> and generate a random address. This ensures that we always know when we
> have a random address and udev won't get upset about it.
> 
> Additionally, tighten up some of the log messages and clean up the
> formatting.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams@...el.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: Stefan Assmann <sassmann@...nic.de>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Tested-by: Stefan Assmann <sassmann@...hat.com>

Thanks Mitch. This solves the problem of correctly setting
addr_assign_type.

  Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html