[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51081A94.1090202@codeaurora.org>
Date: Tue, 29 Jan 2013 10:53:08 -0800
From: Stephen Boyd <sboyd@...eaurora.org>
To: Felipe Balbi <balbi@...com>
CC: davem@...emloft.net, mjr@...wisc.edu, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ks8851: convert to threaded IRQ
On 01/28/13 23:16, Felipe Balbi wrote:
> just as it should have been. It also helps
> removing the, now unnecessary, workqueue.
Tested-by: Stephen Boyd <sboyd@...eaurora.org>
> Signed-off-by: Felipe Balbi <balbi@...com>
> ---
> @@ -1505,8 +1485,9 @@ static int ks8851_probe(struct spi_device *spi)
> ks8851_read_selftest(ks);
> ks8851_init_mac(ks);
>
> - ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW,
> - ndev->name, ks);
> + ret = request_threaded_irq(spi->irq, NULL, ks8851_irq,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + ndev->name, ks);
I did notice one thing here. The name of the thread is irq/378-eth%d
(where 378 is the irq number). It seems that ndev->name is not fully
formed until register_netdev() is called and so when the thread is
created, the malformed name is used for the thread name.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists