netdev - Re: [PATCH 0/2] l2tp: fix ancilliary data handling in ip6 recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130129.141239.2228875361542418234.davem@davemloft.net>
Date:	Tue, 29 Jan 2013 14:12:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tparkin@...alix.com
Cc:	netdev@...r.kernel.org, jchapman@...alix.com, celston@...alix.com
Subject: Re: [PATCH 0/2] l2tp: fix ancilliary data handling in ip6 recv

From: Tom Parkin <tparkin@...alix.com>
Date: Mon, 28 Jan 2013 10:48:52 +0000

> l2tp_ip6 was using the IPv4 handler functions for ancilliary data, which meant
> that socket options such as e.g. IPV6_RECVPKTINFO are not correctly passed to
> userspace.
> 
> This patchset:
> 
> 	*  exports the IPv6 recv handler function datagram_recv_ctl so that
> 	   modules may access it
> 	*  updates l2tp_ip6 to use datagram_recv_ctl rather than ip_cmsg_recv

What a mess.

Well, no surprise that usage of these routines is often wrong given
the non-descript names the functions have.

Please rewrite this patch set, starting with a rename of both
datagram_recv_ctl() and datagram_send_ctl() such that you can
tell, by name, that they are ipv6 specific functions.

Please make sure to grep the entire tree and fix up all references,
they are references to the names in comments too.

They currently look like generic routines that might be found in
net/core/datagram.c and might be usable for all protocols, but that's
definitely not the case.

They are ipv6 specific, and if they are exported globally they must
have something expressing their ipv6'ness in their names.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html