netdev - Re: [PATCH net-next] ipv6: Fix inet6_csk_bind_conflict so it builds with user namespaces enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130129.152058.125290063772024411.davem@davemloft.net>
Date:	Tue, 29 Jan 2013 15:20:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, netdev@...kandruth.co.uk,
	eric.dumazet@...il.com, therbert@...gle.com
Subject: Re: [PATCH net-next] ipv6: Fix inet6_csk_bind_conflict so it
 builds with user namespaces enabled

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Tue, 29 Jan 2013 04:16:18 -0800

> 
> When attempting to build linux-next with user namespaces enabled I ran
> into this fun build error.
> 
>   CC      net/ipv6/inet6_connection_sock.o
> .../net/ipv6/inet6_connection_sock.c: In function ‘inet6_csk_bind_conflict’:
> .../net/ipv6/inet6_connection_sock.c:37:12: error: incompatible types when initializing type ‘int’ using
>  type ‘kuid_t’
> .../net/ipv6/inet6_connection_sock.c:54:30: error: incompatible type for argument 1 of ‘uid_eq’
> .../include/linux/uidgid.h:48:20: note: expected ‘kuid_t’ but argument is of type ‘int’
> make[3]: *** [net/ipv6/inet6_connection_sock.o] Error 1
> make[2]: *** [net/ipv6] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> Using kuid_t instead of int to hold the uid fixes this.
> 
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Applied, thanks Eric.