netdev - Re: [PATCH v2] vmxnet3: set carrier state properly on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130129210825.GD14044@hmsreliant.think-freely.org>
Date:	Tue, 29 Jan 2013 16:08:25 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, pv-drivers@...are.com,
	bhutchings@...arflare.com
Subject: Re: [PATCH v2] vmxnet3: set carrier state properly on probe

On Tue, Jan 29, 2013 at 03:44:30PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Tue, 29 Jan 2013 13:36:51 -0500
> 
> > vmxnet3 fails to set netif_carrier_off on probe, meaning that when an interface
> > is opened the __LINK_STATE_NOCARRIER bit is already cleared, and so
> > /sys/class/net/<ifname>/operstate remains in the unknown state.  Correct this by
> > setting netif_carrier_off on probe, like other drivers do.
> > 
> > Also, while we're at it, lets remove the netif_carrier_ok checks from the
> > link_state_update function, as that check is atomically contained within the
> > netif_carrier_[on|off] functions anyway
> > 
> > Tested successfully by myself
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> 
> This doesn't apply to the current 'net' tree.  Please respin.
I based it off net-next.  I'll respin for net
Neil

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html