netdev - Re: [BUG] via-rhine: NOHZ: local_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130129.174702.196275387733819730.davem@davemloft.net>
Date:	Tue, 29 Jan 2013 17:47:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jamie.gloudon@...il.com
Cc:	netdev@...r.kernel.org, rl@...lgate.ch, romieu@...zoreil.com
Subject: Re: [BUG] via-rhine: NOHZ: local_softirq_pending 08

From: Jamie Gloudon <jamie.gloudon@...il.com>
Date: Wed, 23 Jan 2013 20:08:29 -0400

>    While conducting some tests on a VT6105M card. I noticed this message:
> 
> kernel: [  160.311113] NOHZ: local_softirq_pending 08
> 
> I was able to reliably reproduce the error message by setting autoneg off and changing the interface speed from 100 to 10 with ethtool.

I wonder if this is due to some oversights during the NAPI changes
that went in about a year ago.

Francois, if you move rhine_tx() work into the driver's NAPI poll
routine, as you did in:

commit 7ab87ff4c770eed71e3777936299292739fcd0fe
Author: Francois Romieu <romieu@...zoreil.com>
Date:   Fri Jan 6 21:42:26 2012 +0100

    via-rhine: move work from irq handler to softirq and beyond.

I don't think you can't keep using dev_kfree_skb_irq() there.

Francois any objections to this patch?

====================
via-rhine: Don't use dev_kfree_skb_irq() in softirq context.

When the TX reclaim of this driver was moved into NAPI poll,
using dev_kfree_skb_irq() stopped being appropriate.

Use plain dev_kfree_skb() instead.

Reported-by: Jamie Gloudon <jamie.gloudon@...il.com>
Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index 7992b3e..f08e970 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -1801,7 +1801,7 @@ static void rhine_tx(struct net_device *dev)
 					 rp->tx_skbuff[entry]->len,
 					 PCI_DMA_TODEVICE);
 		}
-		dev_kfree_skb_irq(rp->tx_skbuff[entry]);
+		dev_kfree_skb(rp->tx_skbuff[entry]);
 		rp->tx_skbuff[entry] = NULL;
 		entry = (++rp->dirty_tx) % TX_RING_SIZE;
 	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html