netdev - Re: [net-next PATCH 2/6] net: cacheline adjust struct inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359444601.7119.9.camel@localhost>
Date:	Tue, 29 Jan 2013 08:30:01 +0100
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, fw@...len.de, netdev@...r.kernel.org,
	pablo@...filter.org, amwang@...hat.com, kaber@...sh.net,
	dborkman@...hat.com
Subject: Re: [net-next PATCH 2/6] net: cacheline adjust struct inet_frags
 for better frag performance

On Mon, 2013-01-28 at 23:23 -0500, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@...hat.com>
> Date: Thu, 24 Jan 2013 15:04:20 +0100
> 
> > +	/* --- read-mostly cacheline boundary (was 24 bytes ago) --- */
> 
> This "24" is context dependent, I assume it applies to 64-bit builds
> rather than 32-bit ones.

True

> Either add the necessary details or just get rid of this part of the
> comment altogether.

I'll remove the comment altogether, and resubmit the patchset.

Thanks for your review. (Hope your flu is gone, and your backlog didn't
grow too big)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html