netdev - RE: [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7124@saturn3.aculab.com>
Date:	Tue, 29 Jan 2013 14:35:13 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Claudiu Manoil" <claudiu.manoil@...escale.com>,
	<netdev@...r.kernel.org>
Cc:	"David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines

> * remove unused members(!): imask, ievent
> * move space consuming interrupt name strings (int_name_* members) to
> external structures, unessential for the driver's hot path
> * keep high priority hot path data within the first 2 cache lines
> 
> This reduces struct gfar_priv_grp from 6 to 3 cache lines.

Does it really matter where the message texts are allocated?
Provided they aren't intermixed with the 'hot' data.
Allocating them separately just seems over complicated.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html