netdev - Re: [PATCH] net: ks8851: convert to threaded IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130128.223157.1855971357181002973.davem@davemloft.net>
Date:	Mon, 28 Jan 2013 22:31:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	balbi@...com
Cc:	sboyd@...eaurora.org, mjr@...wisc.edu, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ks8851: convert to threaded IRQ

From: Felipe Balbi <balbi@...com>
Date: Wed, 23 Jan 2013 15:51:38 +0200

> @@ -1505,7 +1485,8 @@ static int ks8851_probe(struct spi_device *spi)
>  	ks8851_read_selftest(ks);
>  	ks8851_init_mac(ks);
>  
> -	ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW,
> +	ret = request_threaded_irq(spi->irq, NULL, ks8851_irq,
> +			IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>  			  ndev->name, ks);

You need to indent the second and third line of this function call
properly.  It should be:

	ret = function_call(arg1, arg2,
			    arg3, arg4,
			    arg5, arg6, etc.);

not what you have there now which has every line indented differently.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html