netdev - Re: [PATCH 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <EF466712-C5FF-4A91-BDF3-477559B02705@dominion.thruhere.net>
Date:	Wed, 30 Jan 2013 21:03:27 +0100
From:	Koen Kooi <koen@...inion.thruhere.net>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <panto@...oniou-consulting.com>
Subject: Re: [PATCH 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly


Op 30 jan. 2013, om 20:56 heeft Mugunthan V N <mugunthanvnm@...com> het volgende geschreven:

> CPDMA interrupts are not properly acknowledged which leads to interrupt
> storm, only cpdma interrupt 0 is acknowledged in Davinci CPDMA driver.
> Changed cpdma_ctlr_eoi api to acknowledge 1 and 2 interrupts which are
> used for rx and tx respectively.

A brief inspection shows that this still isn't following the TRM, but Pantelis' patch does. Can you please fix this driver to follow the TRM and make it work on both PG1.0 and PG2.0 instead of papering over bugs instead of fixing them properly?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html