netdev - Re: [Patch net-next] openvswitch: adjust skb_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2013 22:46:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [Patch net-next] openvswitch: adjust skb_gso_segment() for rx
 path

From: Cong Wang <amwang@...hat.com>
Date: Wed, 30 Jan 2013 16:38:09 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> skb_gso_segment() is almost always called in tx path,
> except for openvswitch. It calls this function when
> it receives the packet and tries to queue it to user-space.
> In this special case, the ->ip_summed check inside
> skb_gso_segment() is no longer true, as ->ip_summed value
> has different meanings on rx path.
> 
> This patch adjusts skb_gso_segment() so that we can at least
> avoid such warnings on checksum.
> 
> I am not very sure if this is a real fix or just a workaround,
> at least this patch works fine for me, the kernel warning inside
> skb_gso_segment() disappears and the traffic is normal too.
> 
> (Note I only tested it on 2.6.32, but ->ip_summed has never
> been changed since then.)
> 
> Cc: Jesse Gross <jesse@...ira.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Instead of having the crazy test, make the caller
tell the context, TX or RX.

struct sk_buff *__skb_gso_segment(struct sk_buff *skb,
				  netdev_features_t features,
				  bool tx_path);

static inline struct sk_buff *
skb_gso_segment(struct sk_buff *skb, netdev_features_t features)
{
	__skb_gso_segment(skb, features, true);
}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html