netdev - Re: [PATCH v2 0/3] l2tp: fix ancillary data handling in ipv6 recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2013 20:32:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tparkin@...alix.com
Cc:	netdev@...r.kernel.org, jchapman@...alix.com, celston@...alix.com
Subject: Re: [PATCH v2 0/3] l2tp: fix ancillary data handling in ipv6 recv 

From: Tom Parkin <tparkin@...alix.com>
Date: Wed, 30 Jan 2013 14:21:23 +0000

> Patch 0001 includes some minor whitespace change in order to comply with
> checkpatch.pl's style recommendations.

Those whitspace recommendations do not match what we use in the
networking.

A function call shall be indented like so:

	ret = func(arg1, arg2, arg3,
		   arg4, arg5, arg6);

That is, the arguments on the second and subsequent lines shall
be indented to the first column after the openning parenthesis
of the first line.

You must use whatever combination of TAB and space characters are
necessary to achieve it.

If you are indenting only using TAB characters, it is guarenteed
that you are doing it wrong.

You also need to reindent the arguments in function declarations in
the header files that you modified.  The function name is longer on
the first line, therefore the openning parenthesis appears deeper in
the line, and therefore the second and further lines of the
declaration have to be indent adjusted.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html