netdev - Re: [PATCH] tcp: detect SYN/data drop when F-RTO is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130131.142122.1136050451546171164.davem@davemloft.net>
Date:	Thu, 31 Jan 2013 14:21:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ycheng@...gle.com
Cc:	ncardwell@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: detect SYN/data drop when F-RTO is disabled

From: Yuchung Cheng <ycheng@...gle.com>
Date: Thu, 31 Jan 2013 11:16:46 -0800

> On receiving the SYN-ACK, Fast Open checks icsk_retransmit for SYN
> retransmission to detect SYN/data drops. But if F-RTO is disabled,
> icsk_retransmit is reset at step D of tcp_fastretrans_alert() (
> under tcp_ack()) before tcp_rcv_fastopen_synack(). The fix is to use
> total_retrans instead which accounts for SYN retransmission regardless
> the use of F-RTO.
> 
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html