netdev - Re: [PATCH v7 net-next 03/12] bridge: Verify that a vlan is allowed to egress on give port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2013 21:03:16 +0100
From:	Michał Mirosław <mirqus@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	shemminger@...tta.com, bridge@...ts.linux-foundation.org,
	davem@...emloft.net, netdev@...r.kernel.org,
	shmulik.ladkani@...il.com
Subject: Re: [PATCH v7 net-next 03/12] bridge: Verify that a vlan is allowed
 to egress on give port

2013/1/31 Vlad Yasevich <vyasevic@...hat.com>:
> When bridge forwards a frame, make sure that a frame is allowed
> to egress on that port.

For egress checks it might be better to have per-vlan bitmaps of ports
instead. For unicast this doesn't really change anything, but for
broadcast and multicast all ports are checked so reading all bits from
one location is going to be cheaper.

[...]
> -static inline struct net_port_vlans *br_get_vlan_info(struct net_bridge *br)
> +static inline struct net_port_vlans *br_get_vlan_info(
> +                                               const struct net_bridge *br)
>  {
>         return rcu_dereference(br->vlan_info);
>  }
>
> -static inline struct net_port_vlans *nbp_get_vlan_info(struct net_bridge_port *p)
> +static inline struct net_port_vlans *nbp_get_vlan_info(
> +                                               const struct net_bridge_port *p)
>  {
>         return rcu_dereference(p->vlan_info);
>  }

Shouldn't this be in patch 1?

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html