netdev - Re: [PATCH] net: remove redundant checking for sock timer state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130201.010946.584437309593473452.davem@davemloft.net>
Date:	Fri, 01 Feb 2013 01:09:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: remove redundant checking for sock timer state

From: Ying Xue <ying.xue@...driver.com>
Date: Fri, 1 Feb 2013 13:53:00 +0800

> It's unnecessary to check whether the sock timer to be stopped is
> pending or not in sk_stop_timer() as del_timer() will do the same
> thing later.
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>

Did it even occur to you that when this code was written, this
"redundant" testing was also redundant, but that it might have been
done on purpose?

If you are going to change this code, you must understand why it was
written this way, because that is the only context in which you will
be able to justify removing the test.

Otherwise I'm ignoring this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html