netdev - Re: [Patch net-next] openvswitch: adjust skb_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359684544.22074.6.camel@cr0>
Date:	Fri, 01 Feb 2013 10:09:04 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] openvswitch: adjust skb_gso_segment() for rx
 path

On Thu, 2013-01-31 at 17:09 -0800, Jesse Gross wrote:
> 
> I would argue that the meanings are the same on transmit and receive
> but the values that you are likely to see differ depending on the
> path.  With bridging (which includes both Open vSwitch and the bridge)
> it's very difficult to know whether you are on the transmit or receive
> path.  Personally, I would just remove the warning completely.

I would keep it as it is, I fixed several RHEL kernel bugs exposed by
this warning, it is pretty useful for debugging.

...
> 
> You can just drop the change in the block above and gso_send_check()
> will take care of the rest.  Regardless of the state of the incoming
> packet, GSO needs the checksum to be reset to CHECKSUM_PARTIAL in
> order to work.

Right, makes sense.

> 
> I think this is a different problem, unrelated to the checksum issue.
> Can you test this patch:
> http://git.kernel.org/?p=linux/kernel/git/jesse/openvswitch.git;a=commit;h=d9d59089c43fc33eb403cbb928e56c131f191dd5
> 
> I believe it should fix the problem, although there are still a few
> lingering reports that I'm trying to track down.

I will try your patch together with my updated patch.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html