netdev - Re: [net-next 01/11] ixgbe: Reset the NIC if up2tc has changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359705754.17807.5.camel@joe-AO722>
Date:	Fri, 01 Feb 2013 00:02:34 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Amir Hanania <amir.hanania@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 01/11] ixgbe: Reset the NIC if up2tc has changed

On Thu, 2013-01-31 at 23:53 -0800, Jeff Kirsher wrote:
> From: Amir Hanania <amir.hanania@...el.com>
[]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
[]
> @@ -542,6 +540,7 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
>  	int max_frame = dev->mtu + ETH_HLEN + ETH_FCS_LEN;
>  	int i, err = 0;
>  	__u8 max_tc = 0;

This should really be int

> +	__u8 map_chg = 0;

Please use bool/true/false where appropriate.

> @@ -551,15 +550,22 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
[]
> +		if (ets->prio_tc[i] != adapter->ixgbe_ieee_ets->prio_tc[i])
> +			map_chg = 1;
[]
> @@ -568,6 +574,8 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
>  
>  	if (max_tc != netdev_get_num_tc(dev))
>  		err = ixgbe_setup_tc(dev, max_tc);
> +	else if (map_chg)
> +		ixgbe_dcbnl_devreset(dev);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html