netdev - Re: invalid socket structure with ip_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 01 Feb 2013 18:34:16 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Steve Muckle <smuckle@...eaurora.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: invalid socket structure with ip_early_demux

On Fri, 2013-02-01 at 18:27 -0800, Steve Muckle wrote:
> On 02/01/13 18:25, Eric Dumazet wrote:
> > A fix would be to add after :
> > 
> > sk = skb->sk;
> > 
> > the following code :
> > 
> > if (sk && sk->sk_state == TCP_TIME_WAIT)
> > 	sk = NULL;
> 
> Thanks. I assumed the xt_qtaguid code was ok because xt_owner does a
> similar thing - does that also need this fix?
> 

I believe xt_owner only is valid on the OUT path
(LOCAL_OUT and POST_ROUTING), so it shouldnt be an issue.

I fixed netfilter modules in 

commit 0626af3139572610b56376580d11eb65d45d9dd7
Author: Eric Dumazet <edumazet@...gle.com>
Date:   Tue Sep 4 07:49:03 2012 +0000

    netfilter: take care of timewait sockets
    
    Sami Farin reported crashes in xt_LOG because it assumes skb->sk is a
    full blown socket.
    
    Since (41063e9 ipv4: Early TCP socket demux), we can have skb->sk
    pointing to a timewait socket.
    
    Same fix is needed in nfnetlink_log.
    
    Diagnosed-by: Florian Westphal <fw@...len.de>
    Reported-by: Sami Farin <hvtaifwkbgefbaei@...il.com>
    Signed-off-by: Eric Dumazet <edumazet@...gle.com>
    Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html