netdev - Re: linux-next: manual merge of the net-next tree with the net tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2013 11:05:06 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marcelo Ricardo Leitner <mleitner@...hat.com>,
	"YOSHIFUJI Hideaki / 吉藤英明" 
	<yoshfuji@...ux-ipv6.org>
Subject: Re: linux-next: manual merge of the net-next tree with the net tree

Sat, Feb 02, 2013 at 04:22:53AM CET, sfr@...b.auug.org.au wrote:
>Hi all,
>
>Today's linux-next merge of the net-next tree got a conflict in
>net/ipv6/route.c between commit bd30e947207e ("ipv6: do not create
>neighbor entries for local delivery") from the net tree and commit
>c440f1609b65 ("ipv6: Do not depend on rt->n in ip6_pol_route()") from the
>net-next tree.
>
>I fixed it up (I think - see below) and can carry the fix as necessary
>(no action is required).
>
>-- 
>Cheers,
>Stephen Rothwell                    sfr@...b.auug.org.au
>
>diff --cc net/ipv6/route.c
>index 363d8b7,f3328bc..0000000
>--- a/net/ipv6/route.c
>+++ b/net/ipv6/route.c
>@@@ -928,7 -884,7 +884,7 @@@ restart
>  	dst_hold(&rt->dst);
>  	read_unlock_bh(&table->tb6_lock);
>  
>- 	if (!rt->n && !(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_LOCAL)))
> -	if (!(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)))
>++	if (!(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_LOCAL | RTF_GATEWAY)))

I believe that no change here is correct to do. RTF_LOCAL here is needed
only before Yoshifuji's "IPv6 rt->n removal"
	
	
>  		nrt = rt6_alloc_cow(rt, &fl6->daddr, &fl6->saddr);
>  	else if (!(rt->dst.flags & DST_HOST))
>  		nrt = rt6_alloc_clone(rt, &fl6->daddr);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html