[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Feb 2013 16:28:32 +0200
From: Pasi Kärkkäinen <pasik@....fi>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>,
Stephen Hemminger <stephen@...workplumber.org>,
netdev@...r.kernel.org
Subject: Re: Linux 3.6.x kernel crash in tcp_slow_start / bictcp_cong_avoid
with wfica
On Fri, Feb 01, 2013 at 07:51:50PM -0800, Eric Dumazet wrote:
> On Thu, 2013-01-24 at 14:51 +0100, Hannes Frederic Sowa wrote:
> > On Wed, Jan 23, 2013 at 03:47:11PM -0800, Eric Dumazet wrote:
>
> > > Adding some BUG_ON(!tp->snd_cwnd) on every writes to tp->snd_cwnd should
> > > catch the bug.
> >
> > But this is much more convenient, yes. :)
>
> So I did that, and the winner is tcp_process_frto()
>
> if (!(flag & FLAG_DATA_ACKED) && (tp->frto_counter == 1)) {
> /* Prevent sending of new data. */
> tp->snd_cwnd = min(tp->snd_cwnd,
> tcp_packets_in_flight(tp));
> return true;
> }
>
> I'll send two patches for net tree, and the debugging patch for net-next
>
Great! Thanks for doing this. I didn't manage to find the time to do it myself yet :)
I'm happy to test the patches.
-- Pasi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists