netdev - Re: [PATCH] tcp: frto should not set snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130203.160113.1441940891060915058.davem@davemloft.net>
Date:	Sun, 03 Feb 2013 16:01:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ncardwell@...gle.com, ilpo.jarvinen@...sinki.fi, pasik@....fi,
	hannes@...essinduktion.org, stephen@...workplumber.org,
	netdev@...r.kernel.org, ycheng@...gle.com
Subject: Re: [PATCH] tcp: frto should not set snd_cwnd to 0

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 03 Feb 2013 11:13:05 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Commit 9dc274151a548 (tcp: fix ABC in tcp_slow_start())
> uncovered a bug in FRTO code :
> tcp_process_frto() is setting snd_cwnd to 0 if the number
> of in flight packets is 0.
> 
> As Neal pointed out, if no packet is in flight we lost our
> chance to disambiguate whether a loss timeout was spurious.
> 
> We should assume it was a proper loss.
> 
> Reported-by: Pasi Kärkkäinen <pasik@....fi>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html