netdev - Re: [PATCH v2] packet: fix leakage of tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130203.161559.1115448046329506801.davem@davemloft.net>
Date:	Sun, 03 Feb 2013 16:15:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	phil.sutter@...rinet.com, netdev@...r.kernel.org,
	johann.baudy@...-log.net
Subject: Re: [PATCH v2] packet: fix leakage of tx_ring memory

From: Daniel Borkmann <dborkman@...hat.com>
Date: Fri, 01 Feb 2013 18:25:13 +0100

> On 02/01/2013 06:21 PM, Phil Sutter wrote:
>> When releasing a packet socket, the routine packet_set_ring() is
>> reused
>> to free rings instead of allocating them. But when calling it for the
>> first time, it fills req->tp_block_nr with the value of rb->pg_vec_len
>> which in the second invocation makes it bail out since
>> req->tp_block_nr
>> is greater zero but req->tp_block_size is zero.
>>
>> This patch solves the problem by passing a zeroed auto-variable to
>> packet_set_ring() upon each invocation from packet_release().
>>
>> As far as I can tell, this issue exists even since 69e3c75 (net:
>> TX_RING
>> and packet mmap), i.e. the original inclusion of TX ring support into
>> af_packet, but applies only to sockets with both RX and TX ring
>> allocated, which is probably why this was unnoticed all the time.
>>
>> Signed-off-by: Phil Sutter <phil.sutter@...rinet.com>
>> Cc: Johann Baudy <johann.baudy@...-log.net>
>> Cc: Daniel Borkmann <dborkman@...hat.com>
> 
> Acked-by: Daniel Borkmann <dborkman@...hat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html