netdev - Re: [PATCH net-next 1/2] cxgb4: Send Flush Work Request on a TX Queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130202.230446.1136757468633811792.davem@davemloft.net>
Date:	Sat, 02 Feb 2013 23:04:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vipul@...lsio.com
Cc:	netdev@...r.kernel.org, divy@...lsio.com, dm@...lsio.com,
	leedom@...lsio.com, abhishek@...lsio.com, jay@...lsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4: Send Flush Work Request on a TX
 Queue

From: Vipul Pandya <vipul@...lsio.com>
Date: Thu, 31 Jan 2013 19:36:26 +0530

> Send Flush Work Request on a TX Queue if it has unreclaimed TX Descriptors
> and the last time anything was sent on the associated net device was more than
> 5 seconds in the past, issue a flush request on the TX Queue in order to get
> any stranded skb's off the TX Queue.
> 
> Signed-off-by: Jay Hernandez <jay@...lsio.com>
> Signed-off-by: Vipul Pandya <vipul@...lsio.com>

Is the "TX finished" event reporting mechanism supported by this chip
so broken that you cannot use that instead?

Timers and deferred logic to reclaim TX entries is terrible for the
Linux stack.  It means that socket reclaim is delayed, it means that
you really cannot support byte queue limits, it means that TCP Small
Queues won't work properly, it means that packet schedulers can
measure traffic in a wildly inaccurate manner, and so on and so forth.

I'd rather you guys fix these TX reclaim issues properly, rather
than continuing to paper over them with hacks.  A 5 second delay
on TX packet reclaim is absolutely not acceptable.

I'm not applying these two patches, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html