netdev - Re: [PATCH v4] netpoll: protect napi_poll and poll_controller during dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204003257.GA4985@neilslaptop.think-freely.org>
Date:	Sun, 3 Feb 2013 19:32:57 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, ivecera@...hat.com,
	bhutchings@...arflare.com, romieu@...zoreil.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH v4] netpoll: protect napi_poll and poll_controller during
 dev_[open|close]

On Sun, Feb 03, 2013 at 04:05:58PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Sat,  2 Feb 2013 13:51:16 -0500
> 
> > I can't say Im a huge fan of returning -EBUSY in open/close, but I
> > like it better than busy waiting while the poll path completes.
> 
> Sorry Neil, this is a show stopper for me.
> 
> There is no reason why, just because of bad timing, a device open or
> close that would normally succeed, should fail.  And this situation is
> only being created because the mutual exclusion and context handling
> is "hard", well that's too bad :-)
> 

Alright, fair enough Dave.  I'll either covert this to a busy wait, or use a
mutex to do this.
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html