| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130204.130951.535741806527607249.davem@davemloft.net> Date: Mon, 04 Feb 2013 13:09:51 -0500 (EST) From: David Miller <davem@...emloft.net> To: mugunthanvnm@...com Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org Subject: Re: [PATCH v3 2/2] drivers: net:ethernet: cpsw: add support for VLAN From: Mugunthan V N <mugunthanvnm@...com> Date: Fri, 1 Feb 2013 00:33:20 +0530 > diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt > index 6ddd028..99696bf 100644 > --- a/Documentation/devicetree/bindings/net/cpsw.txt > +++ b/Documentation/devicetree/bindings/net/cpsw.txt > @@ -24,6 +24,8 @@ Required properties: > Optional properties: > - ti,hwmods : Must be "cpgmac0" > - no_bd_ram : Must be 0 or 1 > +- default_vlan : Specifies Default VLAN for non tagged packets > + ALE processing > > Note: "ti,hwmods" field is used to fetch the base address and irq > resources from TI, omap hwmod data base during device registration. You guys have to get away from this idea that you can basically pepper devicetree bindings with all sorts of random behavioral knobs like this, it's terrible. Make this an ethtool configurable entity or similar, and don't even think about adding a module parameter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists