netdev - Re: No sysfs directory for openvswitch module when built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130205141139.0189f159@nehalam.linuxnetplumber.net>
Date:	Tue, 5 Feb 2013 14:11:39 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Ben Pfaff <blp@...stanford.edu>
Cc:	Cong Wang <xiyou.wangcong@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jesse Gross <jesse@...ira.com>,
	"David S. Miller" <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: No sysfs directory for openvswitch module when built-in

On Tue, 5 Feb 2013 11:15:54 -0800
Ben Pfaff <blp@...stanford.edu> wrote:

> On Tue, Feb 05, 2013 at 06:49:45PM +0800, Cong Wang wrote:
> > On Tue, Feb 5, 2013 at 2:08 PM, Ben Pfaff <blp@...stanford.edu> wrote:
> > > Stephen Hemminger <stephen@...workplumber.org> writes:
> > >
> > >> On Tue, 29 Jan 2013 22:15:18 +0800
> > >> Cong Wang <xiyou.wangcong@...il.com> wrote:
> > >>
> > >>> Hello, Rusty, Jesse,
> > >>>
> > >>> I met an interesting problem when I compile openvswitch module as a
> > >>> built-in (actually I compile ALL kernel modules as built-in), there is
> > >>> no /sys/module/openvswitch/ directory created by the kernel in this
> > >>> case.
> > >>>
> > >>> What's worse, the user-space init script thinks openvswitch module is
> > >>> not loaded by checking the exist of this directory, therefore refuses
> > >>> to start.
> > >>
> > >> Shouldn't the OVS init script be testing for some other API.
> > >
> > > I agree that's a bug in the OVS init script.  I will fix it.
> > 
> > Thanks for taking care of it, Ben!
> 
> I posted a patch to ovs-dev for review:
>         http://openvswitch.org/pipermail/dev/2013-February/025128.html

Good. The ovsctl test is actually more reliable than the /sys/module
because it means that there isn't some other part broken in the API.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html