netdev - Re: [PATCH v5] netpoll: protect napi_poll and poll_controller during dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130205150713.GB4511@hmsreliant.think-freely.org>
Date:	Tue, 5 Feb 2013 10:07:13 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, ivecera@...hat.com,
	bhutchings@...arflare.com, romieu@...zoreil.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH v5] netpoll: protect napi_poll and poll_controller during
 dev_[open|close]

On Mon, Feb 04, 2013 at 09:06:42PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Mon,  4 Feb 2013 12:40:44 -0500
> 
> > +	/*
> > +	 * Block netpoll from trying to do any rx path servicing.
> > +	 * If we don't do this there is a chance ndo_poll_controller
> > +	 * or ndo_poll may be running while we open the device
> > +	 */
> 
> Please format comments:
> 
> 	/* Like
> 	 * this.
> 	 */
> 
> > +	/*
> > +	 * Don't do any rx activity if the dev_lock mutex is held 
> > +	 * the dev_open/close paths use this to block netpoll activity
> > +	 * while changing device state
> > +	 */
> 
> Same here.
> 
> > +int netpoll_rx_disable(struct net_device *dev)
> > +{
> > +        struct netpoll_info *ni;
> > +	int idx;
> > +        might_sleep();
> > +        idx = srcu_read_lock(&netpoll_srcu);
> > +        ni = srcu_dereference(dev->npinfo, &netpoll_srcu);
> 
> A lot of interesting indentation going on here.
Apologies, Dave, I rushed and forgot to run checkpatch.  I'll resend shortly.
Neil

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html