netdev - Re: [PATCH] batman-adv: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130206172234.GB6008@ritirata.org>
Date:	Wed, 6 Feb 2013 18:22:34 +0100
From:	Antonio Quartulli <ordex@...istici.org>
To:	Emil Goode <emilgoode@...il.com>
Cc:	lindner_marek@...oo.de, siwu@....tu-chemnitz.de,
	davem@...emloft.net, b.a.t.m.a.n@...ts.open-mesh.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] batman-adv: Remove unused variable

Hi Emil,

On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> The commit ed242d01 removed a node parameter from iterators.
> This patch removes a hlist_node struct that is no longer used.
> 
> Sparse gives a warning:
> 
> net/batman-adv/originator.c:411:21: warning:
> 	unused variable ‘node_tmp’ [-Wunused-variable]
> 
> Signed-off-by: Emil Goode <emilgoode@...il.com>

On which tree did you base your patch?
I cannot find the commit you are referring to (ed242d01) and the patch does not
apply (neither on net nor net-next).

Other than that the variable is used a couple of lines below (in the code we
have)...

Regards,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Content of type "application/pgp-signature" skipped